Re: [PATCH] [gdb/build] Add warning_prefix_default/error_prefix_default constants

>>>>> "Tom" == Tom de Vries <[email protected]> writes:

Tom> Post-commit review of commit f33422af6d8 ("[gdb/build] Fix cli/cli-style.c
Tom> build error with C++20") pointed out the need for a comment for a
Tom> reinterpret_cast [1].

Tom> While reviewing the comment in gdb/top.c for bd_heavy_horizontal et al, I
Tom> realized I could use the same style:
Tom> ...
Tom> static const char bd_heavy_horizontal[] = u8"\u2501";
Tom> ...
Tom> and get rid of the reinterpret_cast.

Tom> Add warning_prefix_default and error_prefix_default constants, and copy
Tom> the comment from gdb/top.c.

Looks good to me.
Approved-By: Tom Tromey <[email protected]>

Tom