Re: [PATCH 1/2] gdb/linux-tdep: clearer variable names in linux_get_siginfo_type

Tom Tromey <[email protected]>
Newsgroups gmane.comp.gdb.patches
Message-ID <[email protected]>
>>>>> "Simon" == Simon Marchi <[email protected]> writes:

Simon> Instead of reusing the single variable `type`, use distinct variables
Simon> for the various types created.  I find it more readable this way, it's
Simon> easier to track what's being added to what.

Simon> Do other cleanups at the same time, like NULL -> nullptr, removing some
Simon> `struct` keywords, and moving variable declarations to the point of
Simon> first use.

Looks good, thanks.
Approved-By: Tom Tromey <[email protected]>

Tom
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.