Re: grass-session integration into core
Stefan Blumentrath <[email protected]> Wed, 9 Jun 2021 07:27:48 +0000
| Newsgroups | gmane.comp.gis.grass.devel |
|---|---|
| Message-ID | <VI1PR02MB50383843AF22A535FC5191C29E369@VI1PR02MB5038.eurprd02.prod.outlook.com> |
--===============1252506646050947451== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_VI1PR02MB50383843AF22A535FC5191C29E369VI1PR02MB5038eurp_" --_000_VI1PR02MB50383843AF22A535FC5191C29E369VI1PR02MB5038eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Appreciate the discussion! I also agree with Vasek here. GRASS session is very useful, esp. in standalone python scripts or when usi= ng GRASS in Jupyter notebooks, or maybe in QGIS Processing for that matter.= ... However, since grass-sessions is an external Python module it has had issue= s due to version changes before. So, a big +1 from my side to include it in core, knowing that my ability to= contribute here with coding is very limited... Being able to just do import grass would be nice indeed, but I am not sure if it is feasible to throw an infor= mative error message if users try to use GRASS functions without a running = session... That said, what would the gain of a pip package be? If you install GRASS yo= u would have the functionality. If you did not install GRASS you could not = use a pip package with grass-session like functionality anyway, no? Cheers Stefan From: grass-dev <[email protected]> On Behalf Of Markus Net= eler Sent: onsdag 9. juni 2021 08:55 To: GRASS developers list <[email protected]> Subject: [GRASS-dev] grass-session integration into core Hi devs, Vaclav Petras <[email protected]<mailto:[email protected]>> s= chrieb am Mi., 9. Juni 2021, 05:22: ...anyway, I think the ultimate fix is to build usable images from GRASS so= urce code without a 3rd party library which is not an official dependency. = Either GRASS needs grass-session to work and then it should be part of the = source code or GRASS should be fixed to work without it. - You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://eur01.safelinks.pro= tection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2FOSGeo%2Fgrass%2Fpull%= 2F1624%23issuecomment-857341278&data=3D04%7C01%7C%7C0986cc6aea0f4415406208d= 92b138ceb%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637588185234423158%7= CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi= LCJXVCI6Mn0%3D%7C1000&sdata=3DX8lKLIFGs0xQC%2FhcmXPvFGkKzDyaf%2FNkAAA7yJKgz= bg%3D&reserved=3D0>, Following this comment I'd like to open the discussion: also in my view we = need to make grass-session part of core. And that in a way that it can be s= plit out easily as a pip package or whatever appropriate. Opinions are welcome! Best Markus --_000_VI1PR02MB50383843AF22A535FC5191C29E369VI1PR02MB5038eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only; font-family:"Calibri",sans-serif; mso-fareast-language:EN-US;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.WordSection1 {page:WordSection1;} --></style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3D"NO-BOK" link=3D"blue" vlink=3D"purple" style=3D"word-wrap:bre= ak-word"> <div class=3D"WordSection1"> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">Hi,<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">Appreciate the discussion!<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">I also agree with Vasek here.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">GRASS session is very useful, esp. in standalone python scripts or wh= en using GRASS in Jupyter notebooks, or maybe in QGIS Processing for that m= atter….<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">However, since grass-sessions is an external Python module it has had= issues due to version changes before.<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">So, a big +1 from my side to include it in core, knowing that my abil= ity to contribute here with coding is very limited…<o:p></o:p></span>= </p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">Being able to just do<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">import grass<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">would be nice indeed, but I am not sure if it is feasible to throw an= informative error message if users try to use GRASS functions without a ru= nning session…<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">That said, what would the gain of a pip package be? If you install GR= ASS you would have the functionality. If you did not install GRASS you coul= d not use a pip package with grass-session like functionality anyway, no?<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">Cheers<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US">Stefan<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN-US" style=3D"mso-fareast-language:E= N-US"><o:p> </o:p></span></p> <div style=3D"border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm = 0cm 0cm"> <p class=3D"MsoNormal"><b><span lang=3D"EN-US">From:</span></b><span lang= =3D"EN-US"> grass-dev <[email protected]> <b>On Behalf Of </b>Markus Neteler<br> <b>Sent:</b> onsdag 9. juni 2021 08:55<br> <b>To:</b> GRASS developers list <[email protected]><br> <b>Subject:</b> [GRASS-dev] grass-session integration into core<o:p></o:p><= /span></p> </div> <p class=3D"MsoNormal"><o:p> </o:p></p> <div> <div> <p class=3D"MsoNormal" style=3D"margin-bottom:12.0pt">Hi devs,<o:p></o:p></= p> <div> <div> <p class=3D"MsoNormal">Vaclav Petras <<a href=3D"mailto:notifications@gi= thub.com">[email protected]</a>> schrieb am Mi., 9. Juni 2021, 05= :22:<o:p></o:p></p> </div> <blockquote style=3D"border:none;border-left:solid #CCCCCC 1.0pt;padding:0c= m 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p>...anyway, I think the ultimate fix is to build usable images from GRASS= source code without a 3rd party library which is not an official dependenc= y. Either GRASS needs grass-session to work and then it should be part of t= he source code or GRASS should be fixed to work without it.<o:p></o:p></p> <p><span style=3D"font-size:12.0pt;color:#666666">—<br> You are receiving this because you modified the open/close state.<br> Reply to this email directly, <a href=3D"https://eur01.safelinks.protection= .outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2FOSGeo%2Fgrass%2Fpull%2F1624%= 23issuecomment-857341278&data=3D04%7C01%7C%7C0986cc6aea0f4415406208d92b= 138ceb%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637588185234423158%7CUn= known%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ= XVCI6Mn0%3D%7C1000&sdata=3DX8lKLIFGs0xQC%2FhcmXPvFGkKzDyaf%2FNkAAA7yJKg= zbg%3D&reserved=3D0" target=3D"_blank"> view it on GitHub</a>, <o:p></o:p></span></p> </blockquote> </div> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">Following this comment I'd like to open the discussi= on: also in my view we need to make grass-session part of core. And that in= a way that it can be split out easily as a pip package or whatever appropr= iate.<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">Opinions are welcome!<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> <div> <p class=3D"MsoNormal">Best<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal">Markus<o:p></o:p></p> </div> <div> <p class=3D"MsoNormal"><o:p> </o:p></p> </div> </div> </div> </body> </html> --_000_VI1PR02MB50383843AF22A535FC5191C29E369VI1PR02MB5038eurp_-- --===============1252506646050947451== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ grass-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/grass-dev --===============1252506646050947451==--