Re: [PATCH] Assorted bug fixes
Jindřich Makovička <[email protected]> Wed, 07 Jun 2017 16:37:57 +0000
| Newsgroups | gmane.comp.gnome.apps.gkrellm |
|---|---|
| Message-ID | <CAHmvugcGJjO4m68zFkRsx_OCoopbOUZ7k3k9wE9VrpPaVEY9YA@mail.gmail.com> |
--f403045d558e70e46d0551615c9b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefan, thanks for the reply. The int/long patch just unifies the type usage - the current code mixes unsigned long, signed long and signed int. On Wed, Jun 7, 2017 at 6:00 PM Stefan Gehn <[email protected]> wrote: > Hi, > > On 20/05/17 14:20, Jind=C5=99ich Makovi=C4=8Dka wrote: > > Hi, > > > > I am attaching couple of trivial fixes for bugs reported by recent > > Clang & GCC & AddressSanitizer. > > Sorry for the late reply, I'll look over the patches and will try to > integrate them when I find some time. The int/long changes are not quite > obvious to me right now. The privilege fix is indeed a good idea, > otherwise gkrellmd may accidentally continue running as root. > > Regards, > Stefan > > -- Jind=C5=99ich Makovi=C4=8Dka --f403045d558e70e46d0551615c9b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi Stefan,<div><br></div><div>thanks for the reply. The in= t/long patch just unifies the type usage - the current code mixes unsigned = long, signed long and signed int.</div><br><div class=3D"gmail_quote"><div = dir=3D"ltr">On Wed, Jun 7, 2017 at 6:00 PM Stefan Gehn <<a href=3D"mailt= o:stefan%[email protected]" target=3D"_blank">[email protected]<= /a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0= 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br> <br> On 20/05/17 14:20, Jind=C5=99ich Makovi=C4=8Dka wrote:<br> > Hi,<br> ><br> > I am attaching couple of trivial fixes for bugs reported by recent<br> > Clang & GCC & AddressSanitizer.<br> <br> Sorry for the late reply, I'll look over the patches and will try to<br= > integrate them when I find some time. The int/long changes are not quite<br= > obvious to me right now. The privilege fix is indeed a good idea,<br> otherwise gkrellmd may accidentally continue running as root.<br> <br> Regards,<br> Stefan<br> <br> </blockquote></div></div><div dir=3D"ltr">-- <br></div><div data-smartmail= =3D"gmail_signature"><div dir=3D"ltr">Jind=C5=99ich Makovi=C4=8Dka</div></d= iv> --f403045d558e70e46d0551615c9b--