Re: 1.5.3 xinerama problem

John Ellis <[email protected]> Fri, 22 Oct 2004 13:36:05 -0400
Newsgroups gmane.comp.gnome.apps.gqview.devel
Message-ID <[email protected]>
Chris Bare wrote:
> 
> > There is a new option located in the advanced tab of the option window named
> > 'Full screen size'. Try using this to configure you desired full screen size
> > and
> > location.
> >
> > If it fails to work please report back what you expect, and what GQview is
> > doing
> > (right/wrong).
> 
> With all settings, the full screen display still has a window frame. I'm not
> using gnome, I'm using the old mwm window manager, but this all worked
> perfectly in gqview 1.5.0.

Sorry, I forgot about the window decorations bug, this will be fixed in 1.5.4.

> Second, whenever it tries to place the window on my left monitor, it is off to
> the right by about an inch. This may be because of an interaction with the
> window manager. If that is fixed it may fix all my problems. The full screen
> window should be OverrideRedirect so the WM doesn't interfere with it. I
> assume that's how it was in 1.5.0.

I am now trying to avoid using an OverrideRedirect window for full screen.

> I'd suggest that the default for the "Full screen size" option be "Active
> monitor" rather than "Active Screen", as I think that would do what most
> people expect on either setup.

The default has now been changed to Active monitor, change will be in 1.5.4.

> If there's anything I can test to help fix this, just let me know, I can build
> from cvs if needed.

I have attached a one line patch for src/fullscreen.c to remove window
decorations:

  patch fullscreen.c gqview-1.5.3-fullscreen-fix.patch

Reports of success or failure of the patch to clean things up would be
appreciated.


Greetings,
John

-- 
John Ellis <[email protected]>

http://gqview.sourceforge.net <GQview> | http://gqapplets.sourceforge.net
http://gqmpeg.sourceforge.net <GQmpeg> |                  <panel applets>
gqview-1.5.3-fullscreen-fix.patch (text/plain, 610 B)
Index: fullscreen.c
===================================================================
RCS file: /devel/cvs/gqview/src/fullscreen.c,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- fullscreen.c	24 Sep 2004 04:02:09 -0000	1.22
+++ fullscreen.c	15 Oct 2004 19:57:15 -0000	1.23
@@ -238,6 +238,7 @@
 
 	fs->window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
 	gtk_window_fullscreen(GTK_WINDOW(fs->window));
+	gtk_window_set_decorated(GTK_WINDOW(fs->window), FALSE);
 
 	gtk_window_set_screen(GTK_WINDOW(fs->window), screen);
 	gtk_container_set_border_width(GTK_CONTAINER(fs->window), 0);