Re: Small harmfull patch
Richard Hult <[email protected]> 22 Apr 2003 13:41:42 +0200
| Newsgroups | gmane.comp.gnome.apps.mr-project.devel |
|---|---|
| Organization | CodeFactory AB |
| Message-ID | <[email protected]> |
m=E5n 2003-04-21 klockan 17.15 skrev Benjamin BAYART: > Hi, >=20 > As I was coding to add popup menu to my new view, I got a look at > task_tree_tree_view_button_press_event (file > srv/view/gantt/mg-task-tree.c), to try to understand how it works. >=20 > I guess that the numbers, instead of "actions" can be replaced by > the POPUP_XXX equivalent, which would make the code easier to read and > more consistent in case one add/remove a menu entry... Am I right at it? > As I cannot commit stuff, I just send you this e-mail to remember about > it... Yeah, that code should use enums, good catch. The subject suggests you had a patch, it looks like you might have forgotten to attach it? Regards, Richard --=20 Richard Hult [email protected] CodeFactory AB http://www.codefactory.se/