Re: Small harmfull patch

Le Tue, Apr 22, 2003 at 01:41:42PM +0200, Richard Hult:
> 
> mån 2003-04-21 klockan 17.15 skrev Benjamin BAYART:
> > 	Hi,
> > 
> > As I was coding to add popup menu to my new view, I got a look at
> > task_tree_tree_view_button_press_event (file
> > srv/view/gantt/mg-task-tree.c), to try to understand how it works.
> > 
> > I guess that the numbers, instead of "actions" can be replaced by
> > the POPUP_XXX equivalent, which would make the code easier to read and
> > more consistent in case one add/remove a menu entry... Am I right at it?
> > As I cannot commit stuff, I just send you this e-mail to remember about
> > it...
> 
> Yeah, that code should use enums, good catch. The subject suggests you
> had a patch, it looks like you might have forgotten to attach it?

In some sense, the subject is wrong, I wrote harmfull, while my idea was
harmless :-)

Yes, I do have a patch, I'll send it later in the evening (it's on my
computer at home).

Regards,

	Benjamin.