Re: [PATCH] fix segfault on nntp server connect failure
Heinrich Müller <heinrich.mueller82-gM/[email protected]> Fri, 01 Feb 2013 19:43:09 +0100
| Newsgroups | gmane.comp.gnome.apps.pan.devel |
|---|---|
| Message-ID | <[email protected]> |
Am 01.02.2013 16:59, schrieb Cal Peake:
> Hi,
>
> Attached (and below) is a cut-n-paste job from
> pan/tasks/socket-impl-openssl.cc to pan/tasks/socket-impl-gio.cc that
> fixes a segfault that occurs if we're unable to establish a connection to
> a configured news server.
>
> Technical details: A failure to connect in the function create_channel()
> leaves a GIOChannel pointer uninitialized that then gets passed to
> g_io_channel_{unix,win32}_get_fd().
>
> Kind regards,
>
>
Thanks, pushed to master.