Re: [PATCH] fix segfault on nntp server connect failure

Heinrich Müller posted on Fri, 01 Feb 2013 19:43:09 +0100 as excerpted:

> Am 01.02.2013 16:59, schrieb Cal Peake:
>> Hi,
>>
>> Attached (and below) is a cut-n-paste job from
>> pan/tasks/socket-impl-openssl.cc to pan/tasks/socket-impl-gio.cc that
>> fixes a segfault that occurs if we're unable to establish a connection
>> to a configured news server.
>>
>> Technical details: A failure to connect in the function
>> create_channel() leaves a GIOChannel pointer uninitialized that then
>> gets passed to g_io_channel_{unix,win32}_get_fd().

> Thanks, pushed to master.

That's gotta be the bug I was running into that you weren't seeing, 
Heinrich, and that I hadn't had time to get a backtrace on just yet.  
Once I update I'll try mutating my password so I can't connect, and 
double-check that I'm no longer getting the segfault, but that sure fits 
what I was seeing, so I'm about as positive as I can be without having 
tested it yet, that' it's the fix I needed.  =:^)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


_______________________________________________
Pan-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/pan-devel