Lack of "window icon"

Tom Parker <[email protected]> Thu, 29 Sep 2005 16:09:24 +0200
Newsgroups gmane.comp.gnome.apps.pybliographer
Message-ID <[email protected]>
(I previously reported this as 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=330683 but realised it was an 
upstream problem)

Pybliographic displays the "we have no icon" icon in the top-left corner
of it's window title (this is using Metacity). This is because the application
doesn't set the icon, and neither does the glade files. The following
patch fixes this in the glade file. Was generated with "tla changes --diff", but 
I'm not sure if that's the right way to do things (never used arch before).

Tom Parker

* looking for 
gobry-RCRJoSF0iyBS/hBiO3TeyChFgs6l4Fs9xddQ6fo/[email protected]/pybliographer--stable--1.2--patch-205 to compare 
with
* comparing to gobry-RCRJoSF0iyBS/hBiO3TeyChFgs6l4Fs9xddQ6fo/[email protected]/pybliographer--stable--1.2--patch-205
M  glade/Makefile.am
M  glade/pyblio.glade.in
=> glade/.arch-ids/pyblio.glade.id      glade/.arch-ids/pyblio.glade.in.id
=> glade/pyblio.glade   glade/pyblio.glade.in

* modified files

--- orig/glade/Makefile.am
+++ mod/glade/Makefile.am
@@ -1,4 +1,5 @@
  gladedir = $(datadir)/$(PACKAGE)/glade
+appicondir = $(datadir)/pixmaps

  glade_DATA =                                   \
         fields1.glade                           \
@@ -10,5 +11,10 @@
         config1.glade                           \
         openurl.glade

-EXTRA_DIST = $(glade_DATA)
+EXTRA_DIST = $(glade_DATA) pyblio.glade.in
+
+pyblio.glade: pyblio.glade.in Makefile
+       sed -e 's^\@icondir\@^$(appicondir)^g' \
+       < $(srcdir)/pyblio.glade.in > pyblio.glade.tmp \
+       && mv pyblio.glade.tmp pyblio.glade



--- orig/glade/pyblio.glade
+++ mod/glade/pyblio.glade.in
@@ -12,6 +12,7 @@
    <property name="modal">False</property>
    <property name="resizable">True</property>
    <property name="destroy_with_parent">False</property>
+  <property name="icon">@icondir@/pybliographic.png</property>
    <property name="decorated">True</property>
    <property name="skip_taskbar_hint">False</property>
    <property name="skip_pager_hint">False</property>

-- 
[email protected] - http://tevp.net
Illegitimus non carborundum


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl