Re: [Telepathy] rework of the UI

Le mercredi 13 septembre 2006 à 11:58 -0700, Eitan Isaacson a écrit :
> On Wed, 2006-09-13 at 17:13 +0200, Richard Hult wrote:
> > Hi,
> > 
> > I just took a very quick look at the patch:
> > 
> > * Please try to avoid whitespace-only changes
> > 
> > * Use g_object_set() instead of setting up a gvalue and using
> > g_object_set_property (and when using g_object_set, don't cast the object).
> > 
> > * g_value_transform looks suspicious, is that right? don't you just want
> > to copy the value?
> > 
> > * What's the reason for having the function that returns a hash table
> > with all params?
> 
> I just had an idea: instead of returning a hashtable, we could have a
> function called gossip_account_params_foreach() - One more step in
> hiding the implementation without having to iterate over all the
> parameters a million times.

Seems good to me. I'll try to implement that.

Xavier.

_______________________________________________
Gossip-dev mailing list
[email protected]
http://lists.imendio.com/mailman/listinfo/gossip-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQBFCF786dEBUn2qPAMRAl8/AJ4/VMVYvVQC0dnZI93QhY/A2Z46TQCeLMzG
T8kKPr7evULrwEjVuTRGOR4=
=gFa2
-----END PGP SIGNATURE-----