Re: Patch to guard #define WIN32_LEAN_AND_MEAN

Hi Nick,

Nick Wellnhofer wrote:
> On 09/11/2017 06:33, Joel Hockey wrote:
>> The error I get is because we already have WIN32_LEAN_AND_MEAN defined.
>
> This seems to be the result of Chromium defining the macro on the 
> command line
It is correct to define WIN32_LEAN_AND_MEAN - should be well described 
in MSDN.

> and building with -Werror. This is an untypical setup and I'd suggest 
> to fix it in Chromium. 
I agree that build with -Werror is too restrictive.

> I think it should work to add the following lines to libxml2's BUILD.gn:
>
>     if (is_win) {
>       # libxml2 already defines WIN32_LEAN_AND_MEAN.
>       configs -= [ "//build/config/win:lean_and_mean" ]
>     } 
I disagree with above.

It is more correct do not define WIN32_LEAN_AND_MEAN in libxml and/or 
libxslt code. Better is configure.ac and respective configuation file 
for msvc to define such macro.

[SNIP]

Regards,
Roumen Petrov