Re: l10n/i18n issue in gvfs

Il giorno mer, 19/12/2007 alle 09.58 +0100, Alexander Larsson ha
scritto:
> On Tue, 2007-12-18 at 16:53 +0100, Luca Ferretti wrote:
> 
> >         Making all in po
> >         make[2]: Entering directory `/home/luca/svn/gnome2/gvfs/po'
> >         Makefile:146: *** target pattern contains no `%'.  Stop.
> >         make[2]: Leaving directory `/home/luca/svn/gnome2/gvfs/po'
> >         make[1]: *** [all-recursive] Error 1
> >         make[1]: Leaving directory `/home/luca/svn/gnome2/gvfs'
> >         make: *** [all] Error 2
> >         
> > It seems that the "[encoding: UTF-8]" line is an intltool only
> > feature :-(
> > 
> > So we should:
> >      A. remove all non-ASCII strings from source code to make gettext
> >         happy, or
> >      B. intltoolize (i.e. make gvfs depends on intltool) gvfs
> > 
> > IF you choose option B, I can do it; meanwhile, I'll search non-ASCII
> > strings in sources.
> 
> Offhand I can't think of any non-ascii translated messages in gvfs, but
> if you can find any that are not bugs, then we should go with B imho.

It seems that the issue is related with the +- sign for DVDs 

     if ((hal_device_get_property_bool (d, "storage.cdrom.dvdr")) &&
          (hal_device_get_property_bool (d, "storage.cdrom.dvdplusr")))
        second = _("DVD\xc2\xb1R");
      if (hal_device_get_property_bool (d, "storage.cdrom.dvdrw") &&
          hal_device_get_property_bool (d, "storage.cdrom.dvdplusrw"))
        second = _("DVDxc2\xb1RW");

Note that the second one is missing a \ (xc2 instead \xc2)

I'm going to implement solution B

> 
> > PS about i18n/l10n in gvfs: what about mark for translation messages
> > from gvfs-<program> programs (and maybe adding some beautiful
> > explanation about feature and usage) too?
> 
> Sounds good to me. Wanna send in patches?

OK, I'll try to check