Re: ANNOUNCE: ooo-build-3.2.98.1 released (3.3-alpha1)

--===============1363869664==
Content-Type: multipart/signed;
  boundary="nextPart5869080.37oTc2QWbZ";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart5869080.37oTc2QWbZ
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

17 Eyl=C3=BCl 2010 Cuma g=C3=BCn=C3=BC (saat 17:59:57) Petr Mladek =C5=9Fun=
lar=C4=B1 yazm=C4=B1=C5=9Ft=C4=B1:
> Grr, the new scrip was not added to the released tarball. Please put the
> attached file into the ooo-build-3.2.98.1 directory. Make sure that it
> is executable:
>     =20
>      chmod 755 download_external_sources.sh
>=20
> and run ./download again.
>=20
>=20
> I am sorry for the troubles. I will make sure that it is included in the
> next release.

I didn't check this version, but in previous versions of ooo-build, if a fi=
le=20
could not be downloaded by download script (because of losing network=20
connection for example), it was silently ignoring it. Later during the buil=
d,=20
when you end up with a build error, it may be hard to understand which file=
 is=20
missing.=20

As a solution why don't you define your own system() function in download=20
sctript and check the return value of it every time it's called? So you can=
=20
raise an exception if any of the commands fail, stop the download script=20
immediately and print an error message about it (this is like 'set -e' comm=
and=20
in a shell script). And we can see the file cannot be downloaded and re-
execute the download script if necessary.

This also make people think that all commands executed are really necessary=
,=20
and should not be silently ignored.

=2D-=20
G=C3=B6k=C3=A7en Eraslan
Pardus Developer

--nextPart5869080.37oTc2QWbZ
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iEYEABECAAYFAkyUxPcACgkQZ/1oBRJ7GWujiQCgkD4l9bvGverkjwWV5vU//VgI
6IoAoIWoClDIHtv55sYq6J050DC7N3J6
=6ag0
-----END PGP SIGNATURE-----

--nextPart5869080.37oTc2QWbZ--

--===============1363869664==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline