Re: [PATCH v2 3/6] Opcodes changes for nanoMIPS support.

On 24.07.2026 12:30, Tsing wrote:
> --- a/opcodes/disassemble.c
> +++ b/opcodes/disassemble.c
> @@ -102,6 +102,7 @@
>  #define ARCH_xtensa
>  #define ARCH_z80
>  #define ARCH_z8k
> +#define ARCH_nanomips
>  #endif

Please, like you do elsewhere, insert at the appropriate spot rather than at the
end.

> @@ -556,6 +562,9 @@ disassembler_usage (FILE *stream ATTRIBUTE_UNUSED)
>  #ifdef ARCH_nfp
>    print_nfp_disassembler_options (stream);
>  #endif
> +#ifdef ARCH_nanomips
> +  print_nanomips_disassembler_options (stream);
> +#endif
>  #ifdef ARCH_powerpc
>    print_ppc_disassembler_options (stream);
>  #endif

I think you want to go ahead of nfp here?

> @@ -683,6 +692,11 @@ disassemble_init_for_target (struct disassemble_info * info)
>        info->created_styled_output = true;
>        break;
>  #endif
> +#ifdef ARCH_nanomips
> +    case bfd_arch_nanomips:
> +      info->disassembler_needs_relocs = true;
> +      break;
> +#endif
>  #ifdef ARCH_pru
>      case bfd_arch_pru:
>        info->disassembler_needs_relocs = true;

It's a mess here; maybe best to go right after ARCH_mips?

Jan