Re: Minor Comments on Gmake Internals

Paul Eggert <[email protected]> Sat, 18 Dec 2021 12:22:42 -0800
Newsgroups gmane.comp.gnu.make.devel
Organization UCLA Computer Science Department
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------0lWWNG0KJi6T0zt73u5IusHp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12/18/21 11:43, Jon Forrest wrote:
>=20
> Which brings me to the question of how you guys like to receive changes=
.
> Do you want a formal GitHub PR, or do you accept informal diffs on
> this list, or something else?

Yes, this is not well documented. As =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmas=
on wrote=20
earlier this month in=20
<https://lists.gnu.org/r/bug-make/2021-12/msg00020.html>:

> I found it difficult to figure out how to submit patches to
> this project. The Savannah page suggests the bug tracker, but as af
> writing (and I'm logged in, as "avar") that link appears greyed out in
> the web interface, and has a <span class=3D"disabled">.

I suggest creating a patch by using "git format-patch", and then=20
emailing it to [email protected] by using "git send-email".

Perhaps Paul Smith would have a different preference. Whichever way, it=20
should be documented better. A proposed patch is attached. It doesn't=20
address the bug tracker issue, which still remains.

(A bit self-referential: I'm submitting a patch that says "here's how to=20
submit a patch"!)
--------------0lWWNG0KJi6T0zt73u5IusHp
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-make.texi-Bugs-Prefer-git-format-patch.patch"
Content-Disposition: attachment;
 filename="0001-make.texi-Bugs-Prefer-git-format-patch.patch"
Content-Transfer-Encoding: base64

RnJvbSBhYWViMTM2MTE1YjU0MjNiNmFhYTczYzdkZmI0YzZhNWE3NDYzYzZlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1
PgpEYXRlOiBTYXQsIDE4IERlYyAyMDIxIDEyOjE4OjIwIC0wODAwClN1YmplY3Q6IFtQQVRD
SF0gPT9VVEYtOD9xPyo9MjBtYWtlLnRleGk9MjAoQnVncyk6PTIwUHJlZmVyPTIwPUUyPTgw
PTk4Z2l0Pz0KID0/VVRGLTg/cT89MjBmb3JtYXQtcGF0Y2g9RTI9ODA9OTkuPz0KTUlNRS1W
ZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNv
bnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCi0tLQogZG9jL21ha2UudGV4aSB8IDgg
KysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o
LSkKCmRpZmYgLS1naXQgYS9kb2MvbWFrZS50ZXhpIGIvZG9jL21ha2UudGV4aQppbmRleCAz
ZGVhMjRmMS4uYjI3Yjc5NDUgMTAwNjQ0Ci0tLSBhL2RvYy9tYWtlLnRleGkKKysrIGIvZG9j
L21ha2UudGV4aQpAQCAtNTAwLDcgKzUwMCw3IEBAIEVpdGhlciBzZW5kIGVsZWN0cm9uaWMg
bWFpbCB0bzoKIG9yIHVzZSBvdXIgV2ViLWJhc2VkIHByb2plY3QgbWFuYWdlbWVudCB0b29s
LCBhdDoKIAogQGV4YW1wbGUKLSAgICBodHRwOi8vc2F2YW5uYWguZ251Lm9yZy9wcm9qZWN0
cy9tYWtlLworICAgIGh0dHBzOi8vc2F2YW5uYWguZ251Lm9yZy9wcm9qZWN0cy9tYWtlLwog
QGVuZCBleGFtcGxlCiAKIEBub2luZGVudApAQCAtNTExLDYgKzUxMSwxMiBAQCBpbmNsdWRl
IHRoZSB0eXBlIG9mIG1hY2hpbmUgYW5kIG9wZXJhdGluZyBzeXN0ZW0geW91IGFyZSB1c2lu
Zy4gIE9uZQogd2F5IHRvIG9idGFpbiB0aGlzIGluZm9ybWF0aW9uIGlzIGJ5IGxvb2tpbmcg
YXQgdGhlIGZpbmFsIGxpbmVzIG9mCiBvdXRwdXQgZnJvbSB0aGUgY29tbWFuZCBAc2FtcHtt
YWtlIC0taGVscH0uCiAKK0lmIHlvdSBjYW4gY29udHJpYnV0ZSBwYXRjaGVzLCBwbGVhc2Ug
c3VibWl0IHRoZW0gaW4gQGNvZGV7Z2l0Citmb3JtYXQtcGF0Y2h9IGZvcm1hdC4gIFlvdSBj
YW4gc2VuZCB0aGVtIHZpYSBlbGVjdHJvbmljIG1haWwgZWl0aGVyIGJ5CitydW5uaW5nIEBj
b2Rle2dpdCBzZW5kLWVtYWlsfSwgb3IgYnkgYXR0YWNoaW5nIHRoZW0gdG8geW91ciBlbWFp
bCB0bworQHNhbXB7YnVnLW1ha2VAQGdudS5vcmd9LiAgVGhlIGN1cnJlbnQgZGV2ZWxvcG1l
bnQgcmVwb3NpdG9yeSBjYW4gYmUKK2ZvdW5kIGF0IHRoZSBhYm92ZW1lbnRpb25lZCBTYXZh
bm5haCBVUkwuCisKIEBub2RlIEludHJvZHVjdGlvbiwgTWFrZWZpbGVzLCBPdmVydmlldywg
VG9wCiBAY29tbWVudCAgbm9kZS1uYW1lLCAgbmV4dCwgIHByZXZpb3VzLCAgdXAKIEBjaGFw
dGVyIEFuIEludHJvZHVjdGlvbiB0byBNYWtlZmlsZXMKLS0gCjIuMzMuMQoK
--------------0lWWNG0KJi6T0zt73u5IusHp--