[bug #67740] ordschur - new forms of 3rd argument

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Update of bug #67740 (group octave):

         Planned Release: 11.1.0 (current stable) => 12.1.0 (current default)

    _______________________________________________________

Follow-up Comment #11:

Now that Octave 11 is almost out the door, I can take a look at pushing this
to the development branch.

@Dmitri: per comment #17, can you do a review?  I'll trust your judgement on
this.

Small things I see

1) Order of #includes for Octave is C++ STL, newline separator, liboctave,
newline separator, libinterp

2) Octave uses a space between name and opening parenthesis ("*fcn (*")

3) No need for anonymous function with std::transform

+    std::string keyword = sel_arg.string_value();
+    std::transform(keyword.begin(), keyword.end(), keyword.begin(),
+                   [](unsigned char c)
+                   { return std::tolower(c); });

could just be

+    std::string keyword = sel_arg.string_value();
+    std::transform(keyword.begin(), keyword.end(), keyword.begin(),
tolower);


4) In Texinfo, we need to use @qcode macro if code fragment begins with '"'. 

+a character string, one of @code{"lhp"}, @code{"rhp"}, @code{"udi"}, or

will need to be

+a character string, one of @qcode{"lhp"}, @qcode{"rhp"}, @qcode{"udi"}, or


These are all small coding conventions, rather than anything about the
functionality itself.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67740>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCaYhbagAKCRCqLAuaBUf3
TjnbAQCVkSxvzyyi34wPFLWE92d2l2pO94YgZRYu+WBbvqbiOQD/S/oy+Ic48P3K
iL1MvOVKAP2e0edCfJR227EV2r71cgU=
=MgEq
-----END PGP SIGNATURE-----