[bug #68150] Axis labels should be displayable also for invisible axes objects
Pantxo Diribarne <[email protected]>
| Newsgroups | gmane.comp.gnu.octave.bugs |
|---|---|
| Message-ID | <[email protected]> |
Please use the bug tracker to post updates to a bug report. The mailing list is intended as a read-only notification stream. Info posted to this mailing list address won't appear in the tracker database where it is most useful.
Follow-up Comment #8, bug #68150 (group octave):
I realize that the patch makes one test in zlabel.m fail (I had only run tests
in graphics.cc).
hf = figure ("visible", "off");
unwind_protect
view (3);
hz = zlabel ("zlabel_string");
assert (get (gca, "zlabel"), hz);
assert (get (hz, "type"), "text");
assert (get (hz, "visible"), "off");
assert (get (hz, "string"), "zlabel_string");
assert (get (hz, "color"), get (0, "defaultaxeszcolor"));
unwind_protect_cleanup
close (hf);
end_unwind_protect
The reason why it passes before the patch is that it is currently the
responsibility of the renderer to switch labels visibility... Since the figure
visibility is "off", the renderer returns early and fails to to the switch.
To me this test looks simply makes no sense: when the view is 3D, the z-label
should be "visible", whether or not the figure is "visible" (or that would
mean that all objects in the figure should have their "visible" property "off"
for consistency...). I attached a patch in which I modified that test to
(rightfully) pass.
(file #58363)
_______________________________________________________
Additional Item Attachment:
Name: bug68150c.patch Size: 5,8kio
<https://file.savannah.gnu.org/file/bug68150c.patch?file_id=58363>
AGPL NOTICE
These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-eea52b5e705aceab0b59a30a7e37b2d35bfc1c3a.tar.gz
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68150>
_______________________________________________
Message posté via Savannah
https://savannah.gnu.org/
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCabcTMAAKCRCqLAuaBUf3 TiT7AP4t/Z/FjXrbuy+0tS5/SkDrLv3ysurcu3rYlpVLfMdOUQEA1lRuPIuhXEf2 7L7djVx1t3KI05VC8r5xJ0R+evyjxwY= =ZkAJ -----END PGP SIGNATURE-----