[bug #68198] pkg install not allowing uncompressed packages

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

URL:
  <https://savannah.gnu.org/bugs/?68198>

                 Summary: pkg install not allowing uncompressed packages
                   Group: GNU Octave
               Submitter: rot26
               Submitted: Tue 31 Mar 2026 07:15:16 AM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name:
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Unlocked
                 Release: 11.1.0
        Operating System: Any
           Fixed Release: None
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 31 Mar 2026 07:15:16 AM UTC By: rot26 <rot26>
Packages cannot currently be installed from a directory (versus from .tar.gz
zip etc).

Unless I am missing something, that functionality was available previously but
is currently broken.

A small patch (attached) will fix it.


The following comments in install.m suggest that use of a directory *should*
work (ie that it worked once).

      ## The filename pointed to an uncompressed package to begin with.
      if (isfolder (tgz))
        dirlist = {".", "..", tgz};
      endif
      
      

This is a very useful feature for working on packages ( debugging  broken
packages,creating, learning)  -at least it is for this 'new to Octave' user.
Tell me if this is an X Y thing.

The problem seems to stem from the use of

if exist(name,"file") 
..rather than 
if exist(name,"file") == 2
..or 
if isfile(name)
(the latter is presumably newer and preferable)

This results in a false positive for directories, at a point where the code
needs to test for a regular file only.








    _______________________________________________________
File Attachments:

Name: install.m.diff                 Size: 565B
    <https://file.savannah.gnu.org/file/install.m.diff?file_id=58421>



    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f290f6b25beb8cb99bbe243a6cd2c5fef79ffcde.tar.gz

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68198>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCact0jAAKCRCqLAuaBUf3
ThZ/AP9yZKajclXZr2fUWgk5gyAwK/rAdeOs1/qUhpPNGnMccAD/VcG3TFXAeOev
ssL2xYvL0Zg9eSnAwhEz/UaPzqztlAw=
=b8G2
-----END PGP SIGNATURE-----