[bug #68121] convert isequal to built-in function for performance

Please use the bug tracker to post updates to a bug report.  The mailing list is intended as a read-only notification stream.  Info posted to this mailing list address won't appear in the tracker database where it is most useful.

Follow-up Comment #5, bug #68121 (group octave):

Hi,

I have implemented a C++ built-in version of isequal and isequaln 
to improve performance (as requested in this bug report).

The patch converts the existing M-file implementation to C++ built-in 
functions in libinterp/corefcn/.

Changes:
- New file: libinterp/corefcn/isequal.cc (C++ implementation)
- Modified: libinterp/corefcn/module.mk (add to build)
- Modified: scripts/general/module.mk (remove old M-files)
- Removed: scripts/general/isequal.m and isequaln.m

The implementation supports all data types: numeric, complex, sparse, 
char, struct, cell, and function handles. NaN handling follows MATLAB 
compatibility (NaN != NaN for isequal, NaN == NaN for isequaln).

I have tested this locally with various data types and all tests pass.

Please review and test. Thanks!

Best regards,
Moeness BELGACEM

(file #58422)

    _______________________________________________________

Additional Item Attachment:

Name: isequal-builtin.patch          Size: 14kio
    <https://file.savannah.gnu.org/file/isequal-builtin.patch?file_id=58422>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f290f6b25beb8cb99bbe243a6cd2c5fef79ffcde.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68121>

_______________________________________________
Message posté via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCacvLpwAKCRCqLAuaBUf3
TvbDAP4qxCSI/rdkAun2xQRl879HSq34b90ws8VnxtCjeJkL6gD/eZqGMSBzcM3Z
NAXtJutMsns020hjchJD3hjyl4HcFg4=
=WfK8
-----END PGP SIGNATURE-----