[bug #68121] convert isequal to built-in function for performance
Moeness Belgacem <[email protected]>
| Newsgroups | gmane.comp.gnu.octave.bugs |
|---|---|
| Message-ID | <[email protected]> |
Please use the bug tracker to post updates to a bug report. The mailing list is intended as a read-only notification stream. Info posted to this mailing list address won't appear in the tracker database where it is most useful.
Follow-up Comment #20, bug #68121 (group octave):
Hi Andy, Nicholas, and Dmitri,
FINAL PATCH v6 attached - ready for integration.
Changes:
- C++ built-in implementation (593 lines)
- 13 BIST tests covering all data types
- Bug fixes: sparse matrices (real/complex/bool), double/single precision,
multi-row strings, mixed types, Java objects
- Optimization: quick exit for same object comparison (Andy's suggestion)
- NEWS entry for Octave 12
All tests pass. The patch follows Octave commit guidelines.
Thanks for all the reviews and suggestions!
Best regards,
Moeness
(file #58431)
_______________________________________________________
Additional Item Attachment:
Name: isequal-builtin-v6-final.patch Size: 20kio
<https://file.savannah.gnu.org/file/isequal-builtin-v6-final.patch?file_id=58431>
AGPL NOTICE
These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f290f6b25beb8cb99bbe243a6cd2c5fef79ffcde.tar.gz
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68121>
_______________________________________________
Message posté via Savannah
https://savannah.gnu.org/
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCac0cSwAKCRCqLAuaBUf3 Th/pAPwN/vahINY84u2SNQpxIF4fXaDHZiGTKH6zF4zDLCOelAEAjOGneX0IU2Se 9fqZIK8CD4rcHylxfFHPnGZu2muqfw8= =cOk6 -----END PGP SIGNATURE-----