Re: Patch for compiling with VC8
Brian Paul <[email protected]> Mon, 16 Oct 2006 09:28:24 -0600
| Newsgroups | gmane.comp.graphics.chromium.devel |
|---|---|
| Message-ID | <[email protected]> |
Michael D=FCrig wrote: > = > The patch attached adds support for Visual Studio 2005 (i.e. VC8). > = > - When VC8 is detected in WIN_NT.MK a different set of flags is set. > There are a lot of deprecation warnings. I choose to ignore them (/wd4996= ). > = > - By default the linker produces an external manifest file. This is > problematic for appfaker since an application fails to start when the > manifest is not in the applications directory. I therefore added a > further link step which embeds the manifest into the application's binary. > = > - Some .def files used the DESCRIPTION keyword which is deprecated now. > Since the description was always an empty string I removed it entirely. > = > - I think it is wrong to declare cr_packer_globals DLLDATA > (__declspec(dllimport)) in cr_pack.h/pack_init.c. After all the variable > is exported. I checked in your patch. Not sure about the DLLDATA thing. Maybe = another Windows user can comment. -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easi= er Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1= 21642