Re: More Darwin updates and notes
Brian Paul <[email protected]>
| Newsgroups | gmane.comp.graphics.chromium.devel |
|---|---|
| Message-ID | <[email protected]> |
Christopher Waters wrote: > The attached patch has various fixes, mainly for Darwin, including: > Absolute path names during building. The dynamic linker wasn't > liking the relative paths, making things very difficult. > The OSX ogl headers weren't needed in chromium.h. Moved them to > spu.h and compensated elsewhere > Config Tool naming discrepancy (in wxSizer::Add) fixed. Added > Darwin names to SPU searching. Same regex's needed to escape the period. > Various Darwin adjustments in the faker. Still don't know the > details on the last three functions. > Removed CoreFoundation framework from util (Unnecessary). > Added more error handling to Framework and Bundle loading. Still > not very complete. > > Could someone commit this? That is, if there's no problems with it. In app_faker.c you changed a number of lines from: #ifdef USE_FRAMEWORKS to read: #if USE_FRAMEWORKS Some compilers complain if you try to test the value of an undefined preprocessor symbol. It seems to me that USE_FRAMEWORKS will only get defined on Darwin. So, using #ifdef USE_FRAMEWORKS would seem to be a better choice. -Brian ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php