Re: Re: [Chromium-dev] Chromium 1.9 second release candidate

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463747072-1654105609-1148506326=:6058
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 24 May 2006, Michael Barnes wrote:
> All,
>
> I may have a better patch attached.  If -Werror is needed for building
> cromium, then it might be better just to shut up gcc's bogus warning
> about something that "may be used unitialized".  The flag that shuts
> this up is -Wno-uninitialized.

IMO release code shouldn't use -Werror. ;)

>> From gcc's manpage:
>
>      These warnings are made optional because GNU CC is not smart
>      enough to see all the reasons why the code might be correct
>      despite appearing to have an error.
>
> Uninitialized variables are bugs.  Warnings about them maybe being
> uninitilized being turned into errors, when they are not unitialized,
> is a waste of our time.
>
> Please consider the attached patch.
>
> The patch is against 1.8, but it should apply cleanly to 1.9.
<snip>

This may do better as I ran into another uninitialized error while
compiling 1.9rc2:

Rebuilding dependencies for wetspu_init.c
Compiling wetspu.c
cc1: warnings being treated as errors
wetspu.c: In function =E2=80=98ComputeNormal=E2=80=99:
wetspu.c:128: warning: =E2=80=98p1[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p2[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p3[2]=E2=80=99 may be used uninitialized in
this function
wetspu.c:128: warning: =E2=80=98p4[2]=E2=80=99 may be used uninitialized in
this function
gmake[3]: *** [../../built/wetspu/Linux/wetspu.o] Error 1
gmake[2]: *** [dep] Error 2
gmake[1]: *** [wet.subdir] Error 2
make: *** [spu.subdir] Error 2

Possibly more if I fix this one and let the compile continue. In case
we are wanting to initialize everything, a patch is attached.

- -sandalle

- --
Eric Sandall                     |  Source Mage GNU/Linux Developer
[email protected]                  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  SysAdmin @ Inst. Shock Physics @ WSU
http://counter.li.org/  #196285  |  http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEdNDZHXt9dKjv3WERAsVJAJ0cLf51I6PR/TXUmBxm+YL8V/F7LgCdGivF
APIugkUU0yCTO4vbOysQpNc=3D
=3DeUhr
-----END PGP SIGNATURE-----
---1463747072-1654105609-1148506326=:6058
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=wetspu.c.patch
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.64.0605241432060.6058@cerberus>
Content-Description: 
Content-Disposition: attachment; filename=wetspu.c.patch

ZGlmZiAtTmF1ciBjci0xLjkub3JpZy9zcHUvd2V0L3dldHNwdS5jIGNyLTEu
OS9zcHUvd2V0L3dldHNwdS5jDQotLS0gY3ItMS45Lm9yaWcvc3B1L3dldC93
ZXRzcHUuYwkyMDA2LTA1LTI0IDE0OjE5OjI1LjAwMDAwMDAwMCAtMDcwMA0K
KysrIGNyLTEuOS9zcHUvd2V0L3dldHNwdS5jCTIwMDYtMDUtMjQgMTQ6Mjk6
MTguMDAwMDAwMDAwIC0wNzAwDQpAQCAtMTI1LDcgKzEyNSwxMCBAQA0KIHN0
YXRpYyB2b2lkIENvbXB1dGVOb3JtYWwoIGludCB4LCBpbnQgeSwgZmxvYXQg
blszXSApDQogew0KIAlmbG9hdCBsZW47DQotCWZsb2F0IHAxWzNdLCBwMlsz
XSwgcDNbM10sIHA0WzNdOw0KKwlmbG9hdAlwMVszXSA9IHsgMC4wLCAwLjAs
IDAuMCB9LA0KKwkJcDJbM10gPSB7IDAuMCwgMC4wLCAwLjAgfSwNCisJCXAz
WzNdID0geyAwLjAsIDAuMCwgMC4wIH0sDQorCQlwNFszXSA9IHsgMC4wLCAw
LjAsIDAuMCB9Ow0KIAluWzBdID0gblsxXSA9IG5bMl0gPSAwOw0KIAlwMVsw
XSA9IChmbG9hdCkgeC0xOw0KIAlwMlswXSA9IChmbG9hdCkgeDsNCg==

---1463747072-1654105609-1148506326=:6058--


-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642