Re: Re: [Chromium-dev] Chromium 1.9 second release candidate

Brian Paul <[email protected]> Wed, 24 May 2006 15:35:48 -0600
Newsgroups gmane.comp.graphics.chromium.user,gmane.comp.graphics.chromium.devel
Message-ID <[email protected]>
Michael Barnes wrote:
> All,
> 
> I may have a better patch attached.  If -Werror is needed for building
> cromium, then it might be better just to shut up gcc's bogus warning
> about something that "may be used unitialized".  The flag that shuts
> this up is -Wno-uninitialized.
> 
>>From gcc's manpage:
> 
>       These warnings are made optional because GNU CC is not smart
>       enough to see all the reasons why the code might be correct
>       despite appearing to have an error.

Which version of gcc is that?  I checked the manual for a few versions 
and can't find it.


> Uninitialized variables are bugs.  Warnings about them maybe being
> uninitilized being turned into errors, when they are not unitialized,
> is a waste of our time.
> 
> Please consider the attached patch.
> 
> The patch is against 1.8, but it should apply cleanly to 1.9.

I'm thinking the simplest thing will be to only use -Werror for debug 
builds, as someone previously mentioned.

-Brian


-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642