Re: [Crystal-cvs] SF.net SVN: cry stal:[39380] CS/branches/soc2013/videorecording

Четверг, 13 июня 2013, 13:50 -04:00 от Eric Sunshine <[email protected]>:
>On Thu, Jun 13, 2013 at 12:33 PM,  < [email protected] > wrote:
>> Revision: 39380
>> Author:   stepik777
>> Date:     2013-06-13 16:33:05 +0000 (Thu, 13 Jun 2013)
>
>Nobody mentioned it, so you would not have known, but something to
>keep in mind for the future: When it comes time to merge the branch
>back into trunk, changes to configure.ac usually merge cleanly, but
>changes to configure typically result in conflicts. Consequently, it's
>a good idea to commit configure.ac separately from the generated
>configure so that the configure commit can be ignored at merge time.
>
Ok.

>> +
>> +CS_NOTABLE([avutil], [], [], [$cs_cv_libavutil],
>> +    [AS_IF([test "$cs_cv_libavformat" = yes],
>> +       [CS_CHECK_LIB_WITH([avutil],
>> +           [AC_LANG_PROGRAM(
>> +             [[#include <libavformat/avformat.h>
>> +             #include <libavutil/avutil.h>]],
>> +             [av_register_all();])],
>
>The actual test condition here appears to be identical to that in the
>libavformat test. Is that intended? Usually, you want the test to
>invoke a function which is unique to the library being checked.
>
This library just doesn't contain any initialization functions; I will change this test to call, say, avutil_version(), this should be enough.

>> +           [], [],
>> +           [CS_EMIT_BUILD_RESULT([cs_cv_libavutil], [FFMPEG])], [],
>
>Copy/paste error? (FFMPEG)
>

Initially I added these 2 lines in mk/msvcgen/config.jam:
FFMPEG.AVAILABLE = yes ;
FFMPEG.LIBS = avcodec.lib avformat.lib avutil.lib ;
And in my plugin's Jamfile I have test for FFMPEG.AVAILABLE. Here libraries are tested one by one and avutil is last, so if it is available it means that all others are also available. That's why I named it FFMPEG.This is the first time i'm editing configure.ac, I don't know, maybe there is a better way to do it. Actually it can be not ffmpeg, but its fork libav (at least in Ubuntu only libav is available from default repositories), therefore name ffmpeg isn't always correct.

Also, if you are installing these libraries from default Ubuntu repositories then I recommend to install these libraries with -extra suffix. They contain more codecs, including x264 which is used now by default (you can change it in videorecorder.cfg). Here is list of required packages: libavcodec-extra-53 libavcodec-dev libavformat-extra-53 libavformat-dev libavutil-extra-51 libavutil-dev.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop