Re: [Crystal-cvs] SF.net SVN: crystal:[39380] CS/branches/soc2013/videorecording

On Thu, Jun 13, 2013 at 3:09 PM, Stepan Podoskin <[email protected]> wrote:
> Четверг, 13 июня 2013, 13:50 -04:00 от Eric Sunshine <[email protected]>:
>>On Thu, Jun 13, 2013 at 12:33 PM,  < [email protected] > wrote:
>>The actual test condition here appears to be identical to that in the
>>libavformat test. Is that intended? Usually, you want the test to
>>invoke a function which is unique to the library being checked.
>>
> This library just doesn't contain any initialization functions; I will change this test to call, say, avutil_version(), this should be enough.

That sounds reasonable.

>>> +           [CS_EMIT_BUILD_RESULT([cs_cv_libavutil], [FFMPEG])], [],
>>
>>Copy/paste error? (FFMPEG)
>
> Initially I added these 2 lines in mk/msvcgen/config.jam:
> FFMPEG.AVAILABLE = yes ;
> FFMPEG.LIBS = avcodec.lib avformat.lib avutil.lib ;
> And in my plugin's Jamfile I have test for FFMPEG.AVAILABLE. Here libraries are tested one by one and avutil is last, so if it is available it means that all others are also available. That's why I named it FFMPEG.This is the first time i'm editing configure.ac, I don't know, maybe there is a better way to do it. Actually it can be not ffmpeg, but its fork libav (at least in Ubuntu only libav is available from default repositories), therefore name ffmpeg isn't always correct.

As an (apparently) diverging fork of ffmpeg, naming the variable LIBAV
rather than FFMPEG would make sense. (It also would allow a separate
ffmpeg check to added to the build system, without confusion, if ever
needed in the future.) You would, of course, want to adjust
msvcgen/config.jam and your plugin's Jamfile appropriately to reflect
the new name.

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop