Re: [Crystal-cvs] SF.net SVN: crystal:[39466] CS/trunk/include/csutil/variant.h

On 08.07.2013 15:06, [email protected] wrote:
> @@ -38,7 +38,7 @@
>  /// Type of the values that can be contained within a csVariant.
>  enum csVariantType
>  {
> -  // Signed 32-bit integer (long)
> +  /// Signed 32-bit integer (long)
>    CSVAR_LONG,

Hm, I probably would have rather chosen a name like CSVAR_INT32.
Unless it's really a long, then the current name is appropriate.
– The pitfall here is that “long” is _not_ consistently 32-bit… on Win64
it is, but on Linux x86_64 it's 64-bit!

>    /// csMatrix3 type
> +  // TODO: quaternion instead?
>    CSVAR_MATRIX3,

…I always though 3x3 matrices could represent more potential
transformations than quaternions. (Aren't those limited to rotations? My
knowledge is somewhat lacking here.)

>    /// csTransform type
> +  // TODO: remove?
>    CSVAR_TRANSFORM,

Removal because (a) it doesn't really fit into the envisioned use
case(s) for csVariant or (b) because you don't like csTransform?
If it's (b), perhaps you'd like a 4x4 matrix more?

-f.r.

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

_______________________________________________
Crystal-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/crystal-develop

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlHa8IIACgkQNCTzcE/07ewIvgCeJC+h5JwoQGYWDpVw8Bm41nIc
jCgAnjrzc96airCOk/3Er1i17FacTlFd
=dlDQ
-----END PGP SIGNATURE-----