pngcp and pngfix still need fixing (following up: libpng version 1.6.38)

On Thu, Sep 15, 2022 at 8:14 AM John Bowler <
[email protected]> wrote:
>
> > pngcp and pngfix still need fixing
>
> Glenn dropped pngcp because it clashes with a pre-existing command of the
same name; you can just delete it.  pngfix is still distributed but its
utility is limited; it was mainly there to fix up PNG files with a
particular zlib data bug.  I don't think it is necessary any longer.  Pull
it and see who screams.  In fact the whole of contrib/tools can go; contrib
is there to avoid transfer of copyright, contrib/tools is there as a
sort-of compromise for things involved in development process.   Nothing in
contrib/tools is used in the build.

pngcp is marked as a test program in Makefile.am, and yet, some of the
external libpng building and packaging developers insist on shipping it,
alongside pngfix and png-fix-itxt. The fact that pngcp and
pngfix/png-fix-itxt are in the same contrib directory doesn't help. I
suppose that either renaming pngcp to something else (e.g. pngcopy) and/or
moving it to a different directory *could* help.

If pngcp.dfa is meant to be as a conftest, then I would be inclined to move
both pngcp.c and pngcp.dfa to their own glorify directory, say,
contrib/pngcp/ or contrib/pngcopy/, which could then work not unlike
contrib/gregbook/ or contrib/pngminus/.

On a more general note, the continuous integration testing does not
currently include contrib stuff that's independent of the configure script
or cmake file, but I would like to augment it. For example,
contrib/pngminus has its own makefile, and also its own cmake file; the
scripts ci/ci_cmake.sh and ci/ci_legacy.sh should pick them up. After
that's done, we can remove third-party contributions from the main
configure script or cmake file, and avoid further confusion on what
constitutes "official libpng tools" and what doesn't.

Sincerely,
Cosmin

_______________________________________________
png-mng-implement mailing list
png-mng-implement-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/png-mng-implement