Re: [PATCH] Sony Clie SJ33 memory stick

--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I think this is the answer then -- if you clean up this patch, I'll bless
it for Greg to send on for 2.4/5/6

Matt

On Wed, Oct 22, 2003 at 03:03:40PM -0700, Stephen Hemminger wrote:
> On Wed, 22 Oct 2003 12:11:18 -0700
> Matthew Dharm <[email protected]> wrote:
>=20
> > Looking at this, I'm more tempted to remove the test for bType in the I=
RQ
> > -- this isn't the first device I've seen broken like this.  It's using a
> > UFI-style CBI interrupt for a non-UFI device.  This is, apparently, one=
 of
> > many spec violations that windows silently ignores.
> >=20
> > Stephen, what happens if you just remove the check (search the code for=
 the
> > line that shows "CBI IRQ data showed reserved bType")?
>=20
> It works fine with the check removed...
>=20
> diff -Nru a/drivers/usb/storage/transport.c b/drivers/usb/storage/transpo=
rt.c
> --- a/drivers/usb/storage/transport.c	Wed Oct 22 14:52:52 2003
> +++ b/drivers/usb/storage/transport.c	Wed Oct 22 14:52:52 2003
> @@ -821,6 +821,8 @@
>  		}
>  	}
> =20
> +#if 0
> +	/* Removed because some devices do not follow the spec. */
>  	/* If not UFI, we interpret the data as a result code=20
>  	 * The first byte should always be a 0x0
>  	 * The second byte & 0x0F should be 0x0 for good, otherwise error=20
> @@ -830,6 +832,7 @@
>  				us->iobuf[0]);
>  		return USB_STOR_TRANSPORT_ERROR;
>  	}
> +#endif
> =20
>  	switch (us->iobuf[1] & 0x0F) {
>  		case 0x00:=20

--=20
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
net=20
Maintainer, Linux USB Mass Storage Driver

What, are you one of those Microsoft-bashing Linux freaks?
					-- Customer to Greg
User Friendly, 2/10/1999

--gBBFr7Ir9EOA20Yy
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/lwLOIjReC7bSPZARAhaIAKCMv6rmVKDT2IvpwlmJogPplEOxIQCfSQAN
udipT32CZdahLpQDmm0t3YA=
=nRx7
-----END PGP SIGNATURE-----

--gBBFr7Ir9EOA20Yy--


-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel