Re: [PATCH] Fix build without Python

Hi Alec,

On Mon, Aug 28, 2017 at 07:47:04AM +0200, Alec Leamas wrote:
> On 27/08/17 20:36, Baruch Siach wrote:
> > Don't define HAVE_PYTHON35 when PYTHON_LIBS is empty.
> > 
> > Also, don't build Python dependent code when HAVE_PYTHON35 is not
> > defined.
> > 
> > This fixes build failures like:
> 
> [cut]
> 
> Thanks for patch.
> 
> That said, in which context does this happen? Are you building lirc with no
> python available whatsoever?

Yes,

> If so, why?

Some embedded use cases are highly size constrained. Buildroot[1] supports 
building lirc with with various optional dependencies[2] to reduce the size of 
the final image. This patch allows update to the 0.10.0 release, while having 
python as an optional dependency.

The configure.ac/Makefile.am code itself indicates that the python dependency 
is meant to be optional, depending on HAVE_PYTHON35.

Unrelated to that I hit another cross compile issue with setuptools while 
trying to build with python enabled. I'm still investigating that one.

baruch

[1] https://buildroot.org

[2] https://git.busybox.net/buildroot/tree/package/lirc-tools/lirc-tools.mk?id=06cf5c1812e13e9ffd5d4040f2dbaf0f41a8e181

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot