Re: find and replace in files
Davide Ficano <[email protected]>
| Newsgroups | gmane.comp.ide.komodo.general |
|---|---|
| Message-ID | <[email protected]> |
Trent Mick ha scritto:
> Davide Ficano wrote:
>> IMHO The code can be also added directly on Komodo...
>
> Davide,
> Is there a public repo with your source code? Care to put an attachment
The code will be committed on my svn repo very soon
> on the bug that details the relevant code, or even a patch against
> svn.openkomodo.com for this?
>
> Cheers,
> Trent
>
My code is written from an extension point of view, this means
- I can't access to opener.ko.launch.find2_dialog_args to determine mode so
I use document.getElementById("...") to determine the type of 'Find' operation in progress
- <menuitem value="files"/> has no id so I use document.getElementsByAttribute("...", "...")
These solutions are ugly but they work.
If I submit the patch I must be compliant with find2.p.js implementation? I know you answer :P
This requires to rewrite my code.
If you accept the actual MoreKomodo implementation I can
- add the id="search-in-files" to find2.p.xul (this simplifies access)
- add code directly on find2.p.js _init() and on_unload()
Actually the dialog is a xul window and when it is closed the window.close() is used.
This make difficult (for me) distinguishing between accept or cancel.
If user changes context and then closes (cancelling) window the last settings is *always* stored but this is wrong.
I'm trying to find a solution.
davide
_______________________________________________
Komodo-discuss mailing list
[email protected]
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs
Other options: http://listserv.ActiveState.com/mailman/listinfo/Komodo-discuss