Re: find and replace in files

Davide Ficano wrote:
> If I submit the patch I must be compliant with find2.p.js 
> implementation? I know you answer :P
> This requires to rewrite my code.

That's why I'd be happy to just have you point out what you were doing. 
It would of course be helpful for you to put the patch against 
find2.p.js together, but I don't *expect* you to do the work. :)


> If you accept the actual MoreKomodo implementation I can
> 
> - add the id="search-in-files" to find2.p.xul (this simplifies access)

Agreed. That should definitely be added. I'll add that for subsequent 
5.0.x and 5.1.x builds. Done (see 
http://svn.openkomodo.com/openkomodo/revision?rev=2852):

  komodo r26051 (trunk)
  openkomodo r2852 (trunk)
  komodo r26052 (5.0.x branch)
  openkomodo r2853 (5.0.x branch)

However, can you not just look at the menulist's value:

    document.getElementById("search-in-menu").value

?


> - add code directly on find2.p.js _init() and on_unload()
> 
> Actually the dialog is a xul window and when it is closed the 
> window.close() is used.
> This make difficult (for me) distinguishing between accept or cancel.
> If user changes context and then closes (cancelling) window the last 
> settings is *always* stored but this is wrong.
> I'm trying to find a solution.

Is it wrong to do that? Take this scenario:

- open find dialog
- select find "in Files"
- do one or more "Find Next"'s
- close the dialog with "Cancel"

In that case I think the "in Files" should be saved. That's the way some 
of the other options work. For example, if I:

- open find dialog
- click the "Word" checkbox to search for whole words
- close the dialog with "Cancel"

then the "Word" checked-state *is* saved.



Trent

-- 
Trent Mick
trentm at activestate.com
_______________________________________________
Komodo-discuss mailing list
[email protected]
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs
Other options: http://listserv.ActiveState.com/mailman/listinfo/Komodo-discuss