Re: Unicode Bidi Tests

--===============0263700658==
Content-Type: multipart/alternative; boundary="000000000000a266aa05716e03fe"

--000000000000a266aa05716e03fe
Content-Type: text/plain; charset="UTF-8"

Thanks for spotting this. Indeed this line is wrong and an erroneous carry
over from BidiTest.c . The test failures you found are real and should be
fixed asap.

Regards,
Dov

On Fri, Jul 20, 2018 at 1:49 PM Nico Rieck <[email protected]> wrote:

> Hello,
>
> I noticed the following snippet in
> ./test/unicode-conformance/BidiCharacterTest.c:
>
>         if ((paragraph_dir & (1<<base_dir_mode)) == 0)
>           continue;
>
> which skips ~46k of the ~92k tests. Is this an oversight? Without this
> check, all 92k tests pass except for 18 (the whole "Explicit directional
> overrides applied to paired brackets" group and two others).
>
> --Nico
>
> _______________________________________________
> fribidi mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/fribidi
>

--000000000000a266aa05716e03fe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he=
lvetica,sans-serif">Thanks for spotting this. Indeed this line is wrong and=
 an erroneous carry over from BidiTest.c . The test failures you found are =
real and should be fixed asap.</div><div class=3D"gmail_default" style=3D"f=
ont-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_defaul=
t" style=3D"font-family:arial,helvetica,sans-serif">Regards,</div><div clas=
s=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif">Dov<br=
></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Fri, Jul 20=
, 2018 at 1:49 PM Nico Rieck &lt;<a href=3D"mailto:[email protected]">ni=
[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">H=
ello,<br>
<br>
I noticed the following snippet in<br>
./test/unicode-conformance/BidiCharacterTest.c:<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((paragraph_dir &amp; (1&lt;&lt;base_dir_mod=
e)) =3D=3D 0)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;<br>
<br>
which skips ~46k of the ~92k tests. Is this an oversight? Without this<br>
check, all 92k tests pass except for 18 (the whole &quot;Explicit direction=
al<br>
overrides applied to paired brackets&quot; group and two others).<br>
<br>
--Nico<br>
<br>
_______________________________________________<br>
fribidi mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">fribidi@=
lists.freedesktop.org</a><br>
<a href=3D"https://lists.freedesktop.org/mailman/listinfo/fribidi" rel=3D"n=
oreferrer" target=3D"_blank">https://lists.freedesktop.org/mailman/listinfo=
/fribidi</a><br>
</blockquote></div>

--000000000000a266aa05716e03fe--

--===============0263700658==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZnJpYmlkaSBt
YWlsaW5nIGxpc3QKZnJpYmlkaUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmliaWRpCg==

--===============0263700658==--