Re: Unicode Bidi Tests

--===============1302141950==
Content-Type: multipart/alternative; boundary="00000000000077c3f00571b043e3"

--00000000000077c3f00571b043e3
Content-Type: text/plain; charset="UTF-8"

Thanks again for uncovering this. I have now fixed all 18 remaining bugs,
and released a new version of fribidi v1.0.5.

Regards,
Dov


On Fri, Jul 20, 2018 at 4:09 PM Dov Grobgeld <[email protected]> wrote:

> Thanks for spotting this. Indeed this line is wrong and an erroneous carry
> over from BidiTest.c . The test failures you found are real and should be
> fixed asap.
>
> Regards,
> Dov
>
> On Fri, Jul 20, 2018 at 1:49 PM Nico Rieck <[email protected]> wrote:
>
>> Hello,
>>
>> I noticed the following snippet in
>> ./test/unicode-conformance/BidiCharacterTest.c:
>>
>>         if ((paragraph_dir & (1<<base_dir_mode)) == 0)
>>           continue;
>>
>> which skips ~46k of the ~92k tests. Is this an oversight? Without this
>> check, all 92k tests pass except for 18 (the whole "Explicit directional
>> overrides applied to paired brackets" group and two others).
>>
>> --Nico
>>
>> _______________________________________________
>> fribidi mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/fribidi
>>
>

--00000000000077c3f00571b043e3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he=
lvetica,sans-serif">Thanks again for uncovering this. I have now fixed all =
18 remaining bugs, and released a new version of fribidi v1.0.5.</div><div =
class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif"><b=
r></div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,s=
ans-serif">Regards,</div><div class=3D"gmail_default" style=3D"font-family:=
arial,helvetica,sans-serif">Dov</div><div class=3D"gmail_default" style=3D"=
font-family:arial,helvetica,sans-serif"><br></div></div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr">On Fri, Jul 20, 2018 at 4:09 PM Dov Grobgeld &=
lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=
=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif">Thanks =
for spotting this. Indeed this line is wrong and an erroneous carry over fr=
om BidiTest.c . The test failures you found are real and should be fixed as=
ap.</div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,=
sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family:ari=
al,helvetica,sans-serif">Regards,</div><div class=3D"gmail_default" style=
=3D"font-family:arial,helvetica,sans-serif">Dov<br></div></div><br><div cla=
ss=3D"gmail_quote"><div dir=3D"ltr">On Fri, Jul 20, 2018 at 1:49 PM Nico Ri=
eck &lt;<a href=3D"mailto:[email protected]" target=3D"_blank">nico.riec=
[email protected]</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<b=
r>
<br>
I noticed the following snippet in<br>
./test/unicode-conformance/BidiCharacterTest.c:<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((paragraph_dir &amp; (1&lt;&lt;base_dir_mod=
e)) =3D=3D 0)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;<br>
<br>
which skips ~46k of the ~92k tests. Is this an oversight? Without this<br>
check, all 92k tests pass except for 18 (the whole &quot;Explicit direction=
al<br>
overrides applied to paired brackets&quot; group and two others).<br>
<br>
--Nico<br>
<br>
_______________________________________________<br>
fribidi mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">fribidi@=
lists.freedesktop.org</a><br>
<a href=3D"https://lists.freedesktop.org/mailman/listinfo/fribidi" rel=3D"n=
oreferrer" target=3D"_blank">https://lists.freedesktop.org/mailman/listinfo=
/fribidi</a><br>
</blockquote></div>
</blockquote></div>

--00000000000077c3f00571b043e3--

--===============1302141950==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZnJpYmlkaSBt
YWlsaW5nIGxpc3QKZnJpYmlkaUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmliaWRpCg==

--===============1302141950==--