Building with cmake (was Re: GTKPOD 1.0.0 scripts on FreeBSD current)
Daniele Forsi <[email protected]> Thu, 19 Jul 2012 14:08:51 +0200
| Newsgroups | gmane.comp.ipod.gtkpod |
|---|---|
| Message-ID | <CAN_we7O68NZjGZTUSBY-5nTRyc=CNmwnKM7WPx-y0cNk6_tqZQ@mail.gmail.com> |
2012/7/19 Hans Petter Selasky:
> I have some trouble to get stuff built using cmake. Can someone have a look at
> my attached patches and incorporate them?
thank you for your patches but it will be easier if you change the
subject of your email to reflect its content or is ths still related
to gtkpod 1.0.0?
and since you are using git, please do proper commits with informative
commit messages so you get credit and we get explanations
what is the reason of the following change?
the same kind of declaration in done in other source files but at
least when using autotools gcc is invoked with --std=gnu99
and you are using spaces and tabs inconsistently with surrounding code
(I know that in many files it is inconsistent, but that file is ok, so
don't break it)
- for (gint i = 0; i <
g_list_length(gp_iface->track_commands); ++i) {
+ gint i;
+ for (i = 0; i < g_list_length(gp_iface->track_commands); ++i) {
--
Daniele Forsi
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/