Re: Building with cmake (was Re: GTKPOD 1.0.0 scripts on FreeBSD current)

On Thursday 19 July 2012 14:08:51 Daniele Forsi wrote:
> 2012/7/19 Hans Petter Selasky:
> > I have some trouble to get stuff built using cmake. Can someone have a
> > look at my attached patches and incorporate them?
> 
> thank you for your patches but it will be easier if you change the
> subject of your email to reflect its content or is ths still related
> to gtkpod 1.0.0?

No.

> and since you are using git, please do proper commits with informative
> commit messages so you get credit and we get explanations

Ok. Right now I just want these issued fixed.

> 
> what is the reason of the following change?

Declaring variables inside a for loop is a C++ feature, not a C feature ??

> the same kind of declaration in done in other source files but at
> least when using autotools gcc is invoked with --std=gnu99
> and you are using spaces and tabs inconsistently with surrounding code
> (I know that in many files it is inconsistent, but that file is ok, so
> don't break it)
> 
> -            for (gint i = 0; i <
> g_list_length(gp_iface->track_commands); ++i) {
> +	    gint i;
> +            for (i = 0; i < g_list_length(gp_iface->track_commands); ++i)
> {

At least the compiler over here: cc (GCC) 4.2.1 20070831 patched [FreeBSD]

Complained.

--HPS

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/