Re: (ant) branch master updated: bz-69485 Revert the foreach loop change that was done to FTP.java in 1c80d507f496dde98869890e671edf635bef8dec

I've now pushed a commit to address this issue in FTPTaskMirrorImpl.java 
https://github.com/apache/ant/commit/f862774a9e2d2afe3d25d7116f0672eeb4f3e9bf

-Jaikiran

On 02/12/25 11:41 am, Stefan Bodewig wrote:
> On 2025-12-02, Jaikiran Pai wrote:
>
>> On 01/12/25 11:59 pm, Stefan Bodewig wrote:
>>> On 2025-12-01, <[email protected]> wrote:
>>>> bz-69485 Revert the foreach loop change that was done to FTP.java in 1c80d507f496dde98869890e671edf635bef8dec
>>> FTPTaskMirrorImpl seems to share the same bug, see
>> Indeed. Thank you for catching that Stefan.
> It is easy to forget we have the same business logic duplicated
> here. Ages ago somebody asked for a way that allows commons-net to be
> loaded via a different classloader similar to what we did with JUnit 4.x
> support. I don't believe anybody is really using the "mirror" version in
> practice.
>
>> This one too seems to come from the same 1c80d507f496 commit.
> Yes, and they've not been the only ones over time.
>
>> I will address FTPTaskMirrorImpl.java today and then look into the
>> rest of that big commit.
> You may find it has been partially reverted in different places as well.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>