Re: [PR] IVY-1662: collect updates by conf and check trans itive on old dependency [ant-ivy]

maartenc commented on code in PR #108:
URL: https://github.com/apache/ant-ivy/pull/108#discussion_r3506936322


##########
src/java/org/apache/ivy/ant/IvyDependencyUpdateChecker.java:
##########
@@ -211,15 +223,15 @@ private LatestStrategy getLatestStrategy(IvyNode node) {
         return getSettings().getDefaultLatestStrategy();
     }
 
-    private static ArtifactInfo toArtifactInfo(IvyNode node) {
+    private static ArtifactInfo toArtifactInfo(String revision) {
         return new ArtifactInfo() {
             @Override
             public String getRevision() {
-                return node.getResolvedId().getRevision();
+                return revision;
             }
             @Override
             public long getLastModified() {
-                return node.getLastModified();
+                return 0;

Review Comment:
   Why 0?
   
   With the previous version, the correct lastModified was returned, meaning it could also work with a 'latest-time' strategy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]