Re: [PR] IVY-1662: collect updates by conf and check trans itive on old dependency [ant-ivy]

eric-milles commented on code in PR #108:
URL: https://github.com/apache/ant-ivy/pull/108#discussion_r3506954524


##########
src/java/org/apache/ivy/ant/IvyDependencyUpdateChecker.java:
##########
@@ -211,15 +223,15 @@ private LatestStrategy getLatestStrategy(IvyNode node) {
         return getSettings().getDefaultLatestStrategy();
     }
 
-    private static ArtifactInfo toArtifactInfo(IvyNode node) {
+    private static ArtifactInfo toArtifactInfo(String revision) {
         return new ArtifactInfo() {
             @Override
             public String getRevision() {
-                return node.getResolvedId().getRevision();
+                return revision;
             }
             @Override
             public long getLastModified() {
-                return node.getLastModified();
+                return 0;

Review Comment:
   The new loop does not have an IvyNode for new and old.  Only revision is available and so that is what is bound now to ArtifactInfo.  In a temp change that I did not upload, I used just revision for the one case and the revision and last modified for the other.  But the last modified caused incorrect comparisons.  So just revision now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]