Re: Latest Sample through the REST API contribution

Philip Aston <[email protected]> Tue, 04 Sep 2012 21:44:59 +0100
Newsgroups gmane.comp.java.grinder.devel
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--===============7377542405184556712==
Content-Type: multipart/alternative;
	boundary="------------040902030209020204030106"

This is a multi-part message in MIME format.
--------------040902030209020204030106
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Marc,

Yes, that would be welcome .... if you also fix the doc and the tests
accordingly :-). Please see
http://grinder.sourceforge.net/development/contributing.html#How+to+give+back
for a few notes on contributing. Also, please open a new Feature Request
for this change.

I guess you've modified SMI to hang on to the latest statistics as a
collection of StatisticsSets? Or do I understand you're further
aggregating them (hence the "total")?

- Phil



On 04/09/12 14:11, Marc Holden wrote:
>
> Hello,
>
>  
>
> I am interested in contributing a new REST API that allows for the
> retrieval of the latest sample through the RESP API in addition to
> the cumulative statistics that are currently available.  The changes
> involved would be updates to the net.grinder.console.service.rest.clj
> and net.grinder.console.model.recording.clj.  In my local
> implementation I have also updated the
> net.grinder.console.model.SampleModel interface and
> SampleModelImplementation to expose the total latest statistics
> through a new method call getTotalLatestStatistics().  If there is a
> more preferred way of accessing total statistics of the latest sample,
> I will be happy to make any changes.
>
>  
>
> The reason for this new call was that the data returned from the REST
> API did not always accurately reflect how the application was
> performing when the call was made.   This caused some
>  discrepancies in the data captured through our APM.   
>
>  
>
> Please let me know if this is something people would be interested in
> and I would be happy to contribute the changes I have made.
>
>  
>
> Thanks,
>
>  
>
> -Marc
>
>


--------------040902030209020204030106
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi Marc,<br>
      <br>
      Yes, that would be welcome .... if you also fix the doc and the
      tests accordingly :-). Please see
      <a class="moz-txt-link-freetext" href="http://grinder.sourceforge.net/development/contributing.html#How+to+give+back">http://grinder.sourceforge.net/development/contributing.html#How+to+give+back</a>
      for a few notes on contributing. Also, please open a new Feature
      Request for this change.<br>
      <br>
      I guess you've modified SMI to hang on to the latest statistics as
      a collection of StatisticsSets? Or do I understand you're further
      aggregating them (hence the "total")?<br>
      <br>
      - Phil<br>
      <br>
      <br>
      <br>
      On 04/09/12 14:11, Marc Holden wrote:<br>
    </div>
    <blockquote
cite="mid:CADV_OVUvrgvm2t+o7xyf1jDO=fVJy1ZnEzg3x5AwB9VG1OVVVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org"
      type="cite">
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">Hello,</span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif"> </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">I am
          interested in contributing a new REST API that allows for the
          retrieval of the latest sample through the RESP API in
          addition to
          the cumulative statistics that are currently available.  The
          changes involved would be updates to the
          net.grinder.console.service.rest.clj
          and net.grinder.console.model.recording.clj.  In my local
          implementation I
          have also updated the net.grinder.console.model.SampleModel
          interface and
          SampleModelImplementation to expose the total latest
          statistics through a new
          method call getTotalLatestStatistics().  If there is a more
          preferred way
          of accessing total statistics of the latest sample, I will be
          happy to make any
          changes.</span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif"> </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">The reason
          for this new call was that the data returned from the
          REST API did not always accurately reflect how the application
          was performing
          when the call was made.   This caused some  discrepancies in
          the
          data captured through our APM.   </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif"> </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">Please let
          me know if this is something people would be interested
          in and I would be happy to contribute the changes I have made.</span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif"> </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">Thanks,</span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif"> </span></p>
      <p class="MsoNormal"><span
          style="font-size:12pt;font-family:Arial,sans-serif">-Marc</span></p>
      <br>
    </blockquote>
    <br>
  </body>
</html>

--------------040902030209020204030106--


--===============7377542405184556712==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--===============7377542405184556712==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Grinder-development mailing list
Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/grinder-development

--===============7377542405184556712==--