Re: Latest Sample through the REST API contribution

--===============6431547876032560919==
Content-Type: multipart/alternative; boundary=e0cb4efe2b18649fbb04c8e9ead4

--e0cb4efe2b18649fbb04c8e9ead4
Content-Type: text/plain; charset=ISO-8859-1

Hmmmm,  I was actually a calling
m_totalSampleAccumulator.getLastSampleStatistics() as I thought the
m_totalSampleAccumlator held onto the latest sample data.  Am I
misunderstanding how this works (it certainly wouldn't be the first
time...).

I have updated the unit tests and just need to update the documentation.

Thanks,

-Marc

On Tue, Sep 4, 2012 at 4:44 PM, Philip Aston <[email protected]> wrote:

>  Hi Marc,
>
> Yes, that would be welcome .... if you also fix the doc and the tests
> accordingly :-). Please see
> http://grinder.sourceforge.net/development/contributing.html#How+to+give+backfor a few notes on contributing. Also, please open a new Feature Request
> for this change.
>
> I guess you've modified SMI to hang on to the latest statistics as a
> collection of StatisticsSets? Or do I understand you're further aggregating
> them (hence the "total")?
>
> - Phil
>
>
>
>
> On 04/09/12 14:11, Marc Holden wrote:
>
> Hello,
>
>
>
> I am interested in contributing a new REST API that allows for the
> retrieval of the latest sample through the RESP API in addition to
> the cumulative statistics that are currently available.  The changes
> involved would be updates to the net.grinder.console.service.rest.clj and
> net.grinder.console.model.recording.clj.  In my local implementation I have
> also updated the net.grinder.console.model.SampleModel interface and
> SampleModelImplementation to expose the total latest statistics through a
> new method call getTotalLatestStatistics().  If there is a more preferred
> way of accessing total statistics of the latest sample, I will be happy to
> make any changes.
>
>
>
> The reason for this new call was that the data returned from the REST API
> did not always accurately reflect how the application was performing when
> the call was made.   This caused some  discrepancies in the data captured
> through our APM.
>
>
>
> Please let me know if this is something people would be interested in and
> I would be happy to contribute the changes I have made.
>
>
>
> Thanks,
>
>
>
> -Marc
>
>
>

--e0cb4efe2b18649fbb04c8e9ead4
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hmmmm, =A0I was actually a calling m_totalSampleAccumulator.getLastSampleSt=
atistics() as I thought the m_totalSampleAccumlator held onto the latest sa=
mple data. =A0Am I misunderstanding how this works (it certainly wouldn&#39=
;t be the first time...).<div>
<br></div><div>I have updated the unit tests and just need to update the do=
cumentation.</div><div><br></div><div>Thanks,</div><div><br></div><div>-Mar=
c =A0<br><br><div class=3D"gmail_quote">On Tue, Sep 4, 2012 at 4:44 PM, Phi=
lip Aston <span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=
=3D"_blank">[email protected]</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
 =20
   =20
 =20
  <div text=3D"#000000" bgcolor=3D"#FFFFFF">
    <div>Hi Marc,<br>
      <br>
      Yes, that would be welcome .... if you also fix the doc and the
      tests accordingly :-). Please see
      <a href=3D"http://grinder.sourceforge.net/development/contributing.ht=
ml#How+to+give+back" target=3D"_blank">http://grinder.sourceforge.net/devel=
opment/contributing.html#How+to+give+back</a>
      for a few notes on contributing. Also, please open a new Feature
      Request for this change.<br>
      <br>
      I guess you&#39;ve modified SMI to hang on to the latest statistics a=
s
      a collection of StatisticsSets? Or do I understand you&#39;re further
      aggregating them (hence the &quot;total&quot;)?<br>
      <br>
      - Phil<div><div class=3D"h5"><br>
      <br>
      <br>
      <br>
      On 04/09/12 14:11, Marc Holden wrote:<br>
    </div></div></div><div><div class=3D"h5">
    <blockquote type=3D"cite">
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">Hello,</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">I am
          interested in contributing a new REST API that allows for the
          retrieval of the latest sample through the RESP API in
          addition to
          the=A0cumulative statistics that are currently=A0available. =A0Th=
e
          changes involved would be updates to the
          net.grinder.console.service.rest.clj
          and net.grinder.console.model.recording.clj. =A0In my local
          implementation I
          have also updated the net.grinder.console.model.SampleModel
          interface and
          SampleModelImplementation to expose the total latest
          statistics through a new
          method call getTotalLatestStatistics().=A0 If there is a more
          preferred way
          of accessing total statistics of the latest sample, I will be
          happy to make any
          changes.</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">The reason
          for this new call was that the data returned from the
          REST API did not always accurately reflect how the application
          was performing
          when the call was made. =A0 This caused some =A0discrepancies=A0i=
n
          the
          data captured through our APM. =A0=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">Please let
          me know if this is something people would be interested
          in and I would be happy to contribute the changes I have made.</s=
pan></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">Thanks,</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">=A0</span></p>
      <p class=3D"MsoNormal"><span style=3D"font-size:12pt;font-family:Aria=
l,sans-serif">-Marc</span></p>
      <br>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>

--e0cb4efe2b18649fbb04c8e9ead4--


--===============6431547876032560919==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--===============6431547876032560919==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Grinder-development mailing list
Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/grinder-development

--===============6431547876032560919==--