Re: Latest Sample through the REST API contribution
Philip Aston <[email protected]> Wed, 05 Sep 2012 09:08:46 +0100
| Newsgroups | gmane.comp.java.grinder.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============2589028754904698046== Content-Type: multipart/alternative; boundary="------------030203020403080601080605" This is a multi-part message in MIME format. --------------030203020403080601080605 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sorry, you're completely right. :-) - Phil On 05/09/12 02:01, Marc Holden wrote: > Hmmmm, I was actually a calling > m_totalSampleAccumulator.getLastSampleStatistics() as I thought the > m_totalSampleAccumlator held onto the latest sample data. Am I > misunderstanding how this works (it certainly wouldn't be the first > time...). > > I have updated the unit tests and just need to update the documentation. > > Thanks, > > -Marc > > On Tue, Sep 4, 2012 at 4:44 PM, Philip Aston <[email protected] > <mailto:[email protected]>> wrote: > > Hi Marc, > > Yes, that would be welcome .... if you also fix the doc and the > tests accordingly :-). Please see > http://grinder.sourceforge.net/development/contributing.html#How+to+give+back > for a few notes on contributing. Also, please open a new Feature > Request for this change. > > I guess you've modified SMI to hang on to the latest statistics as > a collection of StatisticsSets? Or do I understand you're further > aggregating them (hence the "total")? > > - Phil > > > > > On 04/09/12 14:11, Marc Holden wrote: >> >> Hello, >> >> >> >> I am interested in contributing a new REST API that allows for >> the retrieval of the latest sample through the RESP API in >> addition to the cumulative statistics that are >> currently available. The changes involved would be updates to >> the net.grinder.console.service.rest.clj and >> net.grinder.console.model.recording.clj. In my local >> implementation I have also updated the >> net.grinder.console.model.SampleModel interface and >> SampleModelImplementation to expose the total latest statistics >> through a new method call getTotalLatestStatistics(). If there >> is a more preferred way of accessing total statistics of the >> latest sample, I will be happy to make any changes. >> >> >> >> The reason for this new call was that the data returned from the >> REST API did not always accurately reflect how the application >> was performing when the call was made. This caused some >> discrepancies in the data captured through our APM. >> >> >> >> Please let me know if this is something people would be >> interested in and I would be happy to contribute the changes I >> have made. >> >> >> >> Thanks, >> >> >> >> -Marc >> >> > > --------------030203020403080601080605 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Sorry, you're completely right. :-)<br> <br> - Phil<br> <br> On 05/09/12 02:01, Marc Holden wrote:<br> </div> <blockquote cite="mid:CADV_OVVC=ZDzXTitzNMR4ar8J21YoGKMcZnjwwTg0DEy+pd+4w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org" type="cite">Hmmmm, I was actually a calling m_totalSampleAccumulator.getLastSampleStatistics() as I thought the m_totalSampleAccumlator held onto the latest sample data. Am I misunderstanding how this works (it certainly wouldn't be the first time...). <div> <br> </div> <div>I have updated the unit tests and just need to update the documentation.</div> <div><br> </div> <div>Thanks,</div> <div><br> </div> <div>-Marc <br> <br> <div class="gmail_quote">On Tue, Sep 4, 2012 at 4:44 PM, Philip Aston <span dir="ltr"><<a moz-do-not-send="true" href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div text="#000000" bgcolor="#FFFFFF"> <div>Hi Marc,<br> <br> Yes, that would be welcome .... if you also fix the doc and the tests accordingly :-). Please see <a moz-do-not-send="true" href="http://grinder.sourceforge.net/development/contributing.html#How+to+give+back" target="_blank">http://grinder.sourceforge.net/development/contributing.html#How+to+give+back</a> for a few notes on contributing. Also, please open a new Feature Request for this change.<br> <br> I guess you've modified SMI to hang on to the latest statistics as a collection of StatisticsSets? Or do I understand you're further aggregating them (hence the "total")?<br> <br> - Phil <div> <div class="h5"><br> <br> <br> <br> On 04/09/12 14:11, Marc Holden wrote:<br> </div> </div> </div> <div> <div class="h5"> <blockquote type="cite"> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">Hello,</span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif"> </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">I am interested in contributing a new REST API that allows for the retrieval of the latest sample through the RESP API in addition to the cumulative statistics that are currently available. The changes involved would be updates to the net.grinder.console.service.rest.clj and net.grinder.console.model.recording.clj. In my local implementation I have also updated the net.grinder.console.model.SampleModel interface and SampleModelImplementation to expose the total latest statistics through a new method call getTotalLatestStatistics(). If there is a more preferred way of accessing total statistics of the latest sample, I will be happy to make any changes.</span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif"> </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">The reason for this new call was that the data returned from the REST API did not always accurately reflect how the application was performing when the call was made. This caused some discrepancies in the data captured through our APM. </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif"> </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">Please let me know if this is something people would be interested in and I would be happy to contribute the changes I have made.</span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif"> </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">Thanks,</span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif"> </span></p> <p class="MsoNormal"><span style="font-size:12pt;font-family:Arial,sans-serif">-Marc</span></p> <br> </blockquote> <br> </div> </div> </div> </blockquote> </div> <br> </div> </blockquote> <br> </body> </html> --------------030203020403080601080605-- --===============2589028754904698046== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ --===============2589028754904698046== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Grinder-development mailing list Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/grinder-development --===============2589028754904698046==--