[jgroups-dev] First view change and JChannel.connected
Bela Ban <[email protected]> Mon, 22 Nov 2010 10:06:09 +0100
| Newsgroups | gmane.comp.java.javagroups.devel |
|---|---|
| Message-ID | <[email protected]> |
In JChannel.up() [line 1349], we have a comment which says that a channel can only be connected after JChannel.connect() returned. So the first view change received by a node won't be able to send a message because the channel is still disconnected. However, subsequent view changes will be able to send messages. I don't like this as it is not symmetrical: if someone gets a view change with itself as member of the view, it should be able to send messages. I changed JChannel.up() and uncommented lines 1356ff, when a view change is received, then connected is set to true. Do you see any adverse effects of this ? The test suite passes, except for the 2 tests which explicitly test this behavior (I changed that, so they pass now). -- Bela Ban Lead JGroups / Clustering Team JBoss ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev _______________________________________________ Javagroups-development mailing list