Re: [jgroups-dev] First view change and JChannel.connected

Vladimir Blagojevic <[email protected]> Mon, 22 Nov 2010 22:27:48 -0300
Newsgroups gmane.comp.java.javagroups.devel
Message-ID <[email protected]>
What if we reserve thread carrying a view to only modify internal 
JGroups structures while we notify client on another thread from the 
pool? That way we could guarantee proper client view notification 
with/without FLUSH installed and client can freely send messages from a 
callback without affecting anyone.

On 10-11-22 6:06 AM, Bela Ban wrote:
> In JChannel.up() [line 1349], we have a comment which says that a 
> channel can only be connected after JChannel.connect() returned.
>
> So the first view change received by a node won't be able to send a 
> message because the channel is still disconnected. However, subsequent 
> view changes will be able to send messages.
>
> I don't like this as it is not symmetrical: if someone gets a view 
> change with itself as member of the view, it should be able to send 
> messages.
>
> I changed JChannel.up() and uncommented lines 1356ff, when a view 
> change is received, then connected is set to true.
>
> Do you see any adverse effects of this ? The test suite passes, except 
> for the 2 tests which explicitly test this behavior (I changed that, 
> so they pass now).
>


------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Javagroups-development mailing list