Re: XML config

I think some of the tests might be a little bit weak, for example:

+    public void testParseInterceptorWithNestedPointcut4() throws IOException {
+        String xml = "<aspect-system><interceptor class='" + TestInterceptor.class.getName() + "'>" +
+        "<pointcut><and><methodName value='myMethod'/><methodAttribute value='xyz'/></and></pointcut>" +
+        "</interceptor></aspect-system>";
+        AspectSystem aspectSystem = aspectSystemParser.parse(xml);
+        InterceptorAspect interceptorAspect = (InterceptorAspect) aspectSystem.getAspects().get(0);
+        assertTrue(interceptorAspect.getPointcut() != null ); 
+    }

It is not actually testing whether the parsed pointcut is an and-pointcut or not...

It could also have a better name, like:
testParsesInterceptorWithNestedAndPointcut


What do you think?


Shash Chatterjee wrote:

>Jon,
>
>  
>
>>Great!
>>
>>The best way is to submit a patch to JIRA:
>>http://jira.codehaus.org/secure/BrowseProject.jspa?id=10102
>>
>>    
>>
>Done. <http://jira.codehaus.org/secure/ViewIssue.jspa?key=NAN-13>
>
>  
>
>>I will try to commit it ASAP.
>>    
>>
>
>Thanks.  Would probably be nice if you got a chance to look it over, since I
>am quite new to Nanning.
>
>Shash
>_______________________________________________
>nanning-dev mailing list
>[email protected]
>http://lists.codehaus.org/mailman/listinfo/nanning-dev
>
>  
>