Re: XML config

"Shash Chatterjee" <[email protected]> Thu, 11 Dec 2003 15:57:31 -0600
Newsgroups gmane.comp.java.nanning.devel
Message-ID <[email protected]>
> I think some of the tests might be a little bit weak, for example:
> 
> It is not actually testing whether the parsed pointcut is an and-
> pointcut or not...
> 

True. It is testing only whether there is a pointcut at all (in other words,
if the parsing failed, it would not have created a pointcut).  The only reason
I didn't test for an and pointcut is because (except for And), all the other
pointcuts are marked private.  MethodAttribute and And are public, but in the
minority.  If those could be changed to public then it is a simple test. 
However, I didn't not know the reason for making them public/private one way
or another, hence left them alone.

> It could also have a better name, like:
> testParsesInterceptorWithNestedAndPointcut
> 
Agreed if you don't mind long names (I prefer long names).

> What do you think?
> 
> Shash Chatterjee wrote:
> 
> >Jon,
> >
> >  
> >
> >>Great!
> >>
> >>The best way is to submit a patch to JIRA:
> >>http://jira.codehaus.org/secure/BrowseProject.jspa?id=10102
> >>
> >>    
> >>
> >Done. <http://jira.codehaus.org/secure/ViewIssue.jspa?key=NAN-13>
> >
> >  
> >
> >>I will try to commit it ASAP.
> >>    
> >>
> >
> >Thanks.  Would probably be nice if you got a chance to look it over, since I
> >am quite new to Nanning.
> >
> >Shash
> >_______________________________________________
> >nanning-dev mailing list
> >[email protected]
> >http://lists.codehaus.org/mailman/listinfo/nanning-dev
> >
> >  
> >
> 
> _______________________________________________
> nanning-dev mailing list
> [email protected]
> http://lists.codehaus.org/mailman/listinfo/nanning-dev