Re: NB 8.2 Issues

Hi Neil,

Regarding the iteration, the current code applies the _dark suffix
before the ImageUtilities code is used, so the order would be
something like:

try image_dark:
image_dark_branding_en_US
image_dark_branding_en
image_dark_branding
image_dark_en_US
image_dark_en
image_dark

if not found, try image:
image_branding_en_US
image_branding_en
image_branding
image_en_US
image_en
image

I think that makes sense with what I saw of the intention of the code,
i.e., you'd want any available dark image if possible, then fallback
to non-dark. It seems a little easier to reason about for me, and it
works with the inverting filters that were added.

With the current iteration scheme, a module developer can provide
images for dark and light, and users can customize the module and
override just one of them with branding. If the iteration changes, and
user would have to override both dark and light if they want to just
provide their own light image, otherwise it would have precedence over
the default dark image.

At least, that's what I've managed to sort out of this. :)

steven

On Wed, Oct 5, 2016 at 2:42 PM, Neil C Smith
<[email protected]> wrote:
> Hi,
>
> On 5 October 2016 at 19:09, benno.markiewicz
> <[email protected]> wrote:
>> IIRC localisation of icons/images is supported. Weeks ago I was first confused while debugging to see generated resource names like image_dark_en or image_dark_de_de, but in this l10n context it makes sense nowDen 5 okt. 2016 8:54 em skrev Steven Yi <[email protected]>:
>
> "totally broken" may be a little harsher than I intended - sorry.
>
> What I meant, though, is that I'd expect the iteration order to be
> something like.
>
> image_branding_dark
> image_branding
> image_en_dark
> image_en
> image_dark
> image
>
> whereas at the moment it's more like
>
> image_dark_branding
> image_dark_en
> image_dark
> image_branding
> image_en
> image
>
> It seems it would be better to try the dark of each potential suffix
> as they're iterated?
>
> Having said that, AFAIK the IDE doesn't add the branding token into
> the image names for the splash, etc.?  In which case, that might not
> make any difference because it'll still come down to splash and
> splash_dark?
>
> Best wishes,
>
> Neil
>
> --
> Neil C Smith
> Artist & Technologist
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org