Re: [tasklist] compiler module feedback

On Tue, 2003-03-11 at 02:03, Tim Lebedkov wrote:
> > Anyway, Jesse Glick reads this newsgroup now and then, and I'm
> > pretty sure he wrote the ant integration module (or at least has
> > done some work on it) so he may have ideas for how this could be
> > done.  Perhaps we'll need a third integration module, one which
> > hooks into the ant module's apis for replacing its output API
> > calls...
> 
> What about the TL API enhancements?

I'm sorry -- what are you referring to here?

> > First, I see that you let each compiler error take up multiple
> > lines in the output.
>
> No. It is an error in the core. The output of a compiler is not parsed well.
> This is why calling javaparser:handleError is not a good idea right now.

Couldn't you simply aggregate strings from multiple lines? It looks as
though new errors are the lines that have an associated Line object.

Yes, I know it's not very clean, but then the compiler module is already
having to do some hacks since it's replacing the IDE compilation
service, masking some menu items, etc.

> > Finally, a very minor comment. The warning icon is a bit larger than
> > the error so it stands out a bit. I had created a warning icon
> > for the javaparser module earlier (when I thought I could get warnings
> > from the background parse - but it turns out they're not generating
> > warnings at all). It's the same as the error icon, but with
> > warning-colors instead. I've attached it, in case you like it.
> 
> I created a big error icon instead.

Ok. But: (WARNING - the below is nitpicking)

* I'd prefer it if these error-views stayed consistent. There already is
  an error icon that's used "everywhere" in the UI.
* These icons look more polished than some of the NetBeans icons.
  Did you draw them? If so, great job - and can you please take a stab
  at fixing some of our other icons too, in particular the PMD one?
  If not, have you made sure we have permission to use these icons?
  (They're not from a product, or from a tool using a GPL license,
  right?)  Unfortunately, icons are treated in much the same way as
  other external downloads - their license has to be reviewed etc.
* Have you tried using .gif instead of .png? I noticed that the icons
  looked great from Mozilla, but in the treetableview, the corners are
  a bit sharp. I think I remember discovering before that
  alpha/translucency is not handled well for .png's on some systems.
* While the icons look great, they're in a bit of a different style
  than the current icons. On the one hand one might argue that they
  look better, but they do stand out slightly.