Re: Request for review JavaFX Editor issue #177224

I have forgotten to CC reviewers@... mailing list.

On Friday 20 of November 2009 10:12:41 you wrote:
> 
> The use-case for "JavaFXDataSupport.createJavaFileEntry" method is in our custom DataLoader (contain .fx and our .fxc file) where we would like to use the same format/attribute when creating a new .fx file from template. It this method would not be exposed in API I expect that should create our own FileEntry which would be very similar implementation as it is in javafx.editor module.
> 
> We do not have any reason for having "createJavaFXNode" method. We have copied the method as well just to follow the same style that is used in API of "java.source" module. Therefore we thought it will useful in the future. Since it seems that it is not, we have removed the method from the patch.
> 
> -- D.
> 
> 
> On Friday 20 of November 2009 03:36:10 you wrote:
> > None of this looks like stuff that could be API except by some  
> > accident of history, and we are making history here, not surviving  
> > it.   I can't imagine why
> > MultiDataObject.Entry createJavaFileEntry(MultiDataObject mdo,  
> > FileObject fxfile)
> > should be public (what do you get if you call it twice?), and even  
> > more cannot imagine what
> > public static Node createJavaFXNode(FileObject javafile)
> > will do for you that DataObject.find(javafile).getNodeDelegate() will  
> > not do for you - if you need some crazy Node subclass, do it in the  
> > DataLoader, get the specific type from somebody's lookup, and handle  
> > the case that you will not really get it - you will have to handle  
> > that case anyway, and it is not useful to potentially have two Node  
> > objects for one file, which is the only imaginable use for this method  
> > my poor mind can conjure.
> > 
> > -Tim
> > 
> > On Nov 19, 2009, at 9:25 PM, Petr Nejedly wrote:
> > 
> > > David Kaspar napsal(a):
> > >> Hi,
> > >> Issue:
> > >> https://netbeans.org/bugzilla/show_bug.cgi?id=177224
> > > [...]
> > >> Review:
> > >> The patch has been reviewed by Martin Ryzl (Dev) and approved by  
> > >> Lukas Hasik (QA).
> > >
> > > Well, at least I would insist on cleaning up the javadoc when you're  
> > > in the API package!
> > >
> > 
> > 
>